Create utils code to name#13
Merged
Merged
Conversation
eduaguilera
reviewed
May 20, 2025
eduaguilera
approved these changes
May 20, 2025
lbm364dl
added a commit
that referenced
this pull request
Apr 1, 2026
…name Create utils code to name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't be dragging both codes and actual names of tibble columns all the time but rather only work with codes, which is less error prone and more efficient. This PR adds some helper functions to add the equivalent column in a given tibble, e.g.,
add_area_nameadds a name column to a tibble that already contains a code column, andadd_area_codeadds a code column to a tibble that already contains a name column.I also became aware of Tidyverse recommendation for dealing with tidy selection R CMD Check notes, which is not how we are doing it (we are currently ignoring warnings using
utils::globalVariables). In the next PR I will try to: